Skip to content

Add matrixportal example #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Nov 6, 2020

Lots of folks have a Matrix Portal now and are possibly being introduced to displayio for the first time with it. See #95 for one example. But I think it's popped up a few other places as well.

The majority of displayio examples are written using board.DISPLAY assuming that they will be run on a device with a built-in display. Any written this way won't work as is on a Matrix Portal.

This PR adds a copy of the simpletest example that has been modified to work on Matrix Portal.

I do wonder if we want to keep the examples seperated like in this PR, or combined into one file with comment / uncomment a section? Or perhaps there is some other possible technical solution that can work with both types of devices without the user having to worry about it as much?

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@FoamyGuy FoamyGuy merged commit 957335c into adafruit:master Nov 6, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 7, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.2 from 5.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#60 from adafruit/fix-super-call

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.3 from 3.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#114 from tannewt/esp32spi_fixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.5 from 5.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#63 from adafruit/ladyada-patch-3

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.6.2 from 3.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#93 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.3 from 2.9.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#96 from FoamyGuy/add_matrixportal_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.9.0 from 1.8.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#38 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.2.5 from 0.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#23 from adafruit/nina-fw-1.7.1-updates

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.7.5 from 1.7.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#50 from tannewt/better_error_handling
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#49 from adafruit/no-https-wifitest
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#45 from tannewt/fix_close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants