-
Notifications
You must be signed in to change notification settings - Fork 74
A few ESP32SPI fixes #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few ESP32SPI fixes #114
Conversation
tannewt
commented
Nov 5, 2020
- Only allow one TLS connection at a time. Nina FW doesn't work well with multiple.
- Raise OSError(23) when out of socket slots.
- Close a socket when a send doesn't complete.
- Don't raise an exception when close fails.
* Only allow one TLS connection at a time. Nina FW doesn't work well with multiple. * Raise OSError(23) when out of socket slots. * Close a socket when a send doesn't complete. * Don't raise an exception when close fails.
I'm trying to test this, but am running into:
The reason for this is because an image file is not being written and it can't open a file that doesn't exist. This could be due to the changes made here. I'll continue to test. |
With the adafruit_esp32spi library from the latest bundle it gives this error instead: |
Could you modify the code so it returns the exception that originates in requests? What example are you trying? You can also mention me on discord so we can debug in real time. |
It looks like it may be caused by the missing content-length header in the PyPortal library. I'm continuing to dig. |
Oh, just got this:
|
Yeah, just got the same error again. I think the content-length thing was a fluke. |
The thing is, the erroring is now consistent rather than intermittent in that it fails 100% of the time now. |
I believe I didn't have your changes in place when I ran into that error. I'm trying again. |
Here's the error with your changes in place:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above error is fixed with adafruit/Adafruit_CircuitPython_Requests#50. In tandem they work great.
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.2 from 5.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#60 from adafruit/fix-super-call Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.3 from 3.5.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#114 from tannewt/esp32spi_fixes Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.5 from 5.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#63 from adafruit/ladyada-patch-3 Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.6.2 from 3.6.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#93 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.3 from 2.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#96 from FoamyGuy/add_matrixportal_example Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.9.0 from 1.8.4: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#38 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.2.5 from 0.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#23 from adafruit/nina-fw-1.7.1-updates Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.7.5 from 1.7.4: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#50 from tannewt/better_error_handling > Merge pull request adafruit/Adafruit_CircuitPython_Requests#49 from adafruit/no-https-wifitest > Merge pull request adafruit/Adafruit_CircuitPython_Requests#45 from tannewt/fix_close