Skip to content

Updates #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 26, 2022
Merged

Updates #58

merged 13 commits into from
Apr 26, 2022

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Apr 26, 2022

While preparing my badge for pycon 2022 I found a whole bunch of things that could be improved. This code is tested on pygamer only, but should apply generally. (In particular, the 'brightness not settable' and 'no accelerometer' paths aren't tested by me)

jepler added 12 commits April 26, 2022 13:51
@jepler
Allow padding to be a float
39d3f9c 
padding_above is in "lines of text" units, so being able to position by
0.3 e.g., is useful to get a desired layout.
@jepler
use bitmap text
0237d66 
in most cases this is more performant and can also use less RAM
@jepler
Fix dimming of display
bae8fe7 
The old code would never brighten again after it went dim.

Now, it will brighten on movement or when `activity()` is called from
outside.
@jepler
Add, use show method to reduce display jank
d566007 
This also removes 'with open(...) as ...:' because for correct
functionality the OnDiskBitmap needs to retain the open file handle for
as long as it exists.

In particular, this fixes a problem where switching to the 'business card'
view with a background image would redraw twice.

Calling `show()` also acts as activity, so it'll brighten the screen.
At present, this is not configurable.
@jepler
remove circuitpython6 compatibility code
eb31a88
@jepler
fix movement check call
cd3f9a8
@jepler
make it OK to call acceleration() if no accelerometer; fix return type
998e0f9
@jepler
use annotations and TYPE_CHECKING
d2df1ef 
.. and eliminate imports no longer used since the change to the
acceleration property
@jepler
changes made by black via pre-commit
c8cbc43
@jepler
fix use of auto_refresh property during display update
e1f96af
@jepler
fix activity() to immediately un-dim screen
4a23749
@jepler
make it OK to call auto_dim_display if brightness is not settable
ee4d7df
ladyada
ladyada approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt test but i figure you know what you're doing

@jepler jepler merged commit a5061b4 into main Apr 26, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 3, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@131849a)
517780a 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AHTx0 to 1.0.11 from 1.0.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#13 from sabadam32/fix_typeing_9
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.5.0 from 4.4.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#56 from Edrig/main
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_MONSTERM4SK to 0.3.3 from 0.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MONSTERM4SK#12 from Neradoc/patch-1
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.14 from 3.10.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#107 from FoamyGuy/debounce_buttons_gif_example
  > change discord badge

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.3.0 from 1.2.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#27 from mfhepp/inverted_outputs
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.8 from 1.5.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#32 from rmblau/main
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_TPA2016 to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_TPA2016#10 from adafruit/doc/add-typing
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.6.6 from 5.6.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#90 from Vsaggiomo/main
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_binascii to 1.2.10 from 1.2.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_binascii#15 from tekktrik/dod/typing-correction-just-blinka
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.5.2 from 0.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#23 from ktkinsey37/typing
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter to 2.0.9 from 2.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter#10 from awordforthat/add-type-annotations
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Magic_Light to 0.9.11 from 0.9.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Magic_Light#10 from ktkinsey37/typing
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.7.1 from 0.7.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#41 from jepler/pulsegroup
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#42 from jepler/diverse-integers
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.7.0 from 3.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#58 from adafruit/updates
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @ladyada