-
Notifications
You must be signed in to change notification settings - Fork 20
Create lsm6ds3.py #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add support to lsm6ds3 IMU (include in board Xiao BLE SENSE)
Thanks for this addition @Edrig. The CI checks failed due to the code needing to be formatted with the Black code formatter. There is a guide page here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code that shows how you can use pre-commit to run all of the same checks that the CI actions are doing. The next few pages in the guide after this one show the individual componenets that make up the checks which you can also run individually without pre-commit but it's much more convenient to run them all at once as shown on this page. |
@FoamyGuy All checks have passed ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me, but I have a few suggested changes.
Thanks for adding support for this different variant of hardware @Edrig
…he proper model number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one commit to change the copyrights to your username and changed a few instances of LSM6DS33
to LSM6DS3
in the docstrings.
This is looking good to me after those changes. Don't have the specific hardware to test but changes make sense for the new class that supports hardware with address 0x6A
Updating https://github.com/adafruit/Adafruit_CircuitPython_AHTx0 to 1.0.11 from 1.0.10: > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#13 from sabadam32/fix_typeing_9 > change discord badge > Patch: Replaced discord badge image > Update .gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.5.0 from 4.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#56 from Edrig/main > change discord badge > Patch: Replaced discord badge image > Updated gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_MONSTERM4SK to 0.3.3 from 0.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_MONSTERM4SK#12 from Neradoc/patch-1 > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.14 from 3.10.13: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#107 from FoamyGuy/debounce_buttons_gif_example > change discord badge Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.3.0 from 1.2.11: > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#27 from mfhepp/inverted_outputs > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.8 from 1.5.7: > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#32 from rmblau/main > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_TPA2016 to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_TPA2016#10 from adafruit/doc/add-typing > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.6.6 from 5.6.5: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#90 from Vsaggiomo/main > change discord badge > Patch: Replaced discord badge image > Updated gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_binascii to 1.2.10 from 1.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_binascii#15 from tekktrik/dod/typing-correction-just-blinka > change discord badge > Patch: Replaced discord badge image > Update .gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.5.2 from 0.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#23 from ktkinsey37/typing > change discord badge > Patch: Replaced discord badge image > Update .gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter to 2.0.9 from 2.0.8: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter#10 from awordforthat/add-type-annotations > change discord badge > Patch: Replaced discord badge image > Update .gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Magic_Light to 0.9.11 from 0.9.10: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Magic_Light#10 from ktkinsey37/typing > change discord badge > Patch: Replaced discord badge image > Update .gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.7.1 from 0.7.0: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#41 from jepler/pulsegroup > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#42 from jepler/diverse-integers > change discord badge > Patch: Replaced discord badge image > Update .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.7.0 from 3.6.4: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#58 from adafruit/updates > change discord badge > Patch: Replaced discord badge image > Update .gitignore
add support to lsm6ds3 IMU
(IMU in board Xiao BLE SENSE)