Use circuitpython_typing.FillBasedLED instead of custom Pixel protocol #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
May 3, 2022
| from typing import Protocol | ||
| except ImportError: | ||
| from typing_extensions import Protocol | ||
| from adafruit_espatcontrol.adafruit_espatcontrol import ESP_ATcontrol |
There was a problem hiding this comment.
I think we need to keep this ESP_ATcontrol line
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 4, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.6.7 from 0.6.4: > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#56 from tekktrik/doc/use-circuitpython-typing > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#55 from tekktrik/dev/allow-37-protocol > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#54 from tekktrik/dev/swap-import-order > change discord badge > Patch: Replaced discord badge image > Updated gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.2.0 from 1.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#22 from matt-land/fix-variable-reference > change discord badge > Patch: Replaced discord badge image > Update .gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins to
circuitpython_typingminimum release that adds this functionality