Skip to content

Swap import orders #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2022
Merged

Swap import orders #54

merged 3 commits into from
May 3, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented May 3, 2022

As is, some imports were happen before the typing import guard in the try/except block kicked in. This moves imports so they won't actually import.

@tekktrik tekktrik requested a review from a team May 3, 2022 01:41
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and changes look good to me. Thanks @tekktrik

@FoamyGuy FoamyGuy merged commit 31b7388 into adafruit:main May 3, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 4, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.6.7 from 0.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#56 from tekktrik/doc/use-circuitpython-typing
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#55 from tekktrik/dev/allow-37-protocol
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#54 from tekktrik/dev/swap-import-order
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.2.0 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#22 from matt-land/fix-variable-reference
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants