Skip to content

fix for #21, always create reference #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2022
Merged

fix for #21, always create reference #22

merged 2 commits into from
May 3, 2022

Conversation

matt-land
Copy link
Contributor

@matt-land matt-land commented May 3, 2022 •
edited
Loading

Quick fix for this, ready for review. I do not have a board handy to test with.

@tekktrik tekktrik requested a review from a team May 3, 2022 20:09
@tekktrik tekktrik linked an issue May 3, 2022 that may be closed by this pull request
Issues saving a displayio.Bitmap #21
Closed
FoamyGuy
FoamyGuy reviewed May 3, 2022
View reviewed changes
@FoamyGuy
Copy link
Contributor

FoamyGuy commented May 3, 2022

I did test the functionality of this and confirmed it does resolve #21 successfully.

I think we can remove the pylint disables unless they are specifically needed for passing CI. I ran pre-commit locally without them and it passed, but perhaps my environment is different or something. Did pylint raise errors for you when you made this PR before those disables were added?

@matt-land
Copy link
Contributor Author

matt-land commented May 3, 2022 •
edited
Loading

I think we can remove the pylint disables unless they are specifically needed for passing CI.

Removed

Did pylint raise errors for you when you made this PR before those disables were added?

yes. If i checkout main and run, I see the following:

 pylint adafruit_bitmapsaver.py 
************* Module adafruit_bitmapsaver
adafruit_bitmapsaver.py:41:22: E1101: Module 'struct' has no 'pack' member (no-member)
adafruit_bitmapsaver.py:44:22: E1101: Module 'struct' has no 'pack' member (no-member)
adafruit_bitmapsaver.py:48:22: E1101: Module 'struct' has no 'pack' member (no-member)
adafruit_bitmapsaver.py:49:22: E1101: Module 'struct' has no 'pack' member (no-member)
adafruit_bitmapsaver.py:50:22: E1101: Module 'struct' has no 'pack' member (no-member)
adafruit_bitmapsaver.py:51:22: E1101: Module 'struct' has no 'pack' member (no-member)
adafruit_bitmapsaver.py:52:22: E1101: Module 'struct' has no 'pack' member (no-member)

------------------------------------------------------------------
Your code has been rated at 5.62/10 (previous run: 5.29/10, +0.33)

@FoamyGuy
Copy link
Contributor

FoamyGuy commented May 3, 2022

we might have some configuration in the .pylintrc file that is making that not get flagged when it runs in CI. Or perhaps it's due to a version difference or something.

FoamyGuy
FoamyGuy approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Tested successfully on PyPortal with the bitmapsaver_simpletest.py from this repo.

Thanks for the fix @matt-land

@FoamyGuy FoamyGuy merged commit b8758f9 into adafruit:main May 3, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 4, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@131849a)
cfb6a27 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.6.7 from 0.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#56 from tekktrik/doc/use-circuitpython-typing
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#55 from tekktrik/dev/allow-37-protocol
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#54 from tekktrik/dev/swap-import-order
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.2.0 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#22 from matt-land/fix-variable-reference
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues saving a displayio.Bitmap
2 participants
@matt-land @FoamyGuy