Skip to content

advertising timeout not available on 5.x #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2020
Merged

advertising timeout not available on 5.x #101

merged 2 commits into from
Aug 23, 2020

Conversation

dhalbert
Copy link
Collaborator

Fixes #100

@roamingthings Could you test? I did a smoke test on 5.3.1 and 6.x. Thanks.

@dhalbert dhalbert requested a review from a team August 23, 2020 14:03
@dhalbert
Copy link
Collaborator Author

336d04e was cherry-picked from #99 (in progress) because the pylint issues are new.

roamingthings
roamingthings approved these changes Aug 23, 2020
View reviewed changes
Copy link

@roamingthings roamingthings left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this version and had no more issues with CircuitPython 5.3.1 on a Feather Bluefruit Sense 👌
Also nice to see how to determine the version of the running CircuitPython binary.

@dhalbert dhalbert merged commit 20f21e7 into adafruit:master Aug 23, 2020
@dhalbert dhalbert deleted the 5.x-no-timeout branch August 23, 2020 14:23
@dhalbert
Copy link
Collaborator Author

In https://github.com/adafruit/Adafruit_CircuitPython_BLE/releases/tag/7.2.1

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 24, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b17b8fd)
61611da 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.1.1 from 4.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#27 from MomsFriendlyRobotCompany/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.2.1 from 7.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#101 from dhalbert/5.x-no-timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roamingthings roamingthings roamingthings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release 7.20 is not compatible with CircuitPython 5.3.x
2 participants
@dhalbert @roamingthings