Skip to content

Release 7.20 is not compatible with CircuitPython 5.3.x #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roamingthings opened this issue Aug 23, 2020 · 1 comment · Fixed by #101
Closed

Release 7.20 is not compatible with CircuitPython 5.3.x #100

roamingthings opened this issue Aug 23, 2020 · 1 comment · Fixed by #101
Assignees

Comments

@roamingthings
Copy link

roamingthings commented Aug 23, 2020

While trying to advertise something using start_advertising() I constantly ran into an error:

...
File "adafruit_ble/init.py", line 191, in start_advertising
TypeError: extra keyword arguments given

After comparing the documentation of CircuitPython 5.3.x and the current version (6.x.x) regarding the underlying call to start_advertisingof Adapter 5.3.x / 6.x.x
I realized that Release 7.2.0 of this library introduced an incompatibility with CircuitPython 5.3.x:

self._adapter.start_advertising(
advertisement_bytes,
scan_response=scan_response_bytes,
connectable=advertisement.connectable,
interval=interval,
timeout=0 if timeout is None else timeout,

Which has too many parameters for CircuitPython 5.3.x

Unfortunately I'm new to (Circuit)Python so I don't know if it would be possible to have a library that is compatible with both versions of CircuitPython.
I also unterstand that (for now) I have to use Version 7.1.0 to be compatible with CircuitPython 5.3.1

@dhalbert
Copy link
Collaborator

Oops, sorry! I will add code to check the version or fall back to no timeout. I will reference you on a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants