Skip to content

Update setup.py #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2020
Merged

Update setup.py #27

merged 1 commit into from
Aug 23, 2020

Conversation

walchko
Copy link
Contributor

@walchko walchko commented Aug 23, 2020

fix setup.py by changing py_modules to packages

@walchko
Update setup.py
8fb679a 
fix setup.py by changing py_modules to packages
@walchko
Copy link
Contributor Author

walchko commented Aug 23, 2020 •
edited
Loading

in reference to this issue.

I also highlighted some other small issues here in the discussion. This pull doesn't address them.

FoamyGuy
FoamyGuy approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I believe it should resolve the issue preventing this lib from being installed via PyPi currently.

I am probably not the best suited person to speak about some of the other things you raised about stuff inside the setup.py file. My experience with it is somewhat limited.

But I had run across this particular issue before so I think the fix is familiar to me.

I would probably recommend to open a new issue with those things highlighted (and with a descriptive title), that way it will be easier for other folks to find and comment on. Many of the project developers hang out on Discord as well at https://adafru.it/discord it's often possible to discuss development details like this within some of the channels on that server.

@walchko walchko mentioned this pull request Aug 23, 2020
Closed
@FoamyGuy
Copy link
Contributor

I tested these changes out locally on a Raspberry Pi and pip3 install does seem to work correctly for me with this version.

@FoamyGuy FoamyGuy merged commit fee9519 into adafruit:master Aug 23, 2020
@FoamyGuy
Copy link
Contributor

@walchko thanks for pointing this out and submitting a fix! The updated version looks to be live on PyPi now. You should be able to install it from there and have the import work now I believe.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 24, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b17b8fd)
61611da 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.1.1 from 4.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#27 from MomsFriendlyRobotCompany/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.2.1 from 7.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#101 from dhalbert/5.x-no-timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walchko @FoamyGuy