lowest_common_ancestor.py static type checking #2329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from master
|
Hey @kanthuc, TravisCI finished with status TravisBuddy Request Identifier: 01014280-e104-11ea-a6dd-d374b9ca78b0 |
…king merge from master
cclauss
requested changes
Aug 18, 2020
|
Please add doctests to function’s where possible. |
|
We can merge when Travis tests are passing. |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* adding static type checking to basic_binary_tree.py * Add static type checking to functions with None return type * Applying code review comments * Added missing import statement * fix spaciing * "cleaned up depth_of_tree" * Add doctests and then streamline display() and is_full_binary_tree() * added static typing to lazy_segment_tree.py * added missing import statement * modified variable names for left and right elements * added static typing to lowest_common_ancestor.py * fixed formatting * modified files to meet style guidelines, edited docstrings and added some doctests * added and fixed doctests in lazy_segment_tree.py * fixed errors in doctests Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added static type checking to lowest_common_ancestor.py towards issue #2128. Also includes changes from PR #2303.
Checklist:
Fixes: #{$ISSUE_NO}.