Skip to content

Remove duplicate Euclidean length method for Vector #5657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tianyizheng02 opened this issue Oct 29, 2021 · 0 comments · Fixed by #5658
Closed

Remove duplicate Euclidean length method for Vector #5657

tianyizheng02 opened this issue Oct 29, 2021 · 0 comments · Fixed by #5658

Comments

@tianyizheng02
Copy link
Contributor

The Vector class currently has two methods, euclidean_length and magnitude, that both calculate the L2 norm of a vector:

Also I noticed that Vector's euclidLength and magnitude methods both do the same thing. Should I open an issue to have one of them removed?

Let's keep euclidean_length. We can keep the tests of magnitude in euclidean_length

Originally posted by @poyea in #5362 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate euclidean_length method in Vector
1 participant
@tianyizheng02