Skip to content

Deduplicate euclidean_length method in Vector #5658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 31, 2021
Merged

Deduplicate euclidean_length method in Vector #5658

merged 15 commits into from
Oct 31, 2021

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Oct 29, 2021 •
edited
Loading

Describe your change:

Removed magnitude method, which was a duplicate of euclidean_length. Also added more unit tests for euclidean_length.

Fixes #5657

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

tianyizheng02 and others added 12 commits October 16, 2021 18:08
@tianyizheng02
Rewrite parts of Vector and Matrix methods
ad6c215
@tianyizheng02
Refactor determinant method and add unit tests
f84d769 
Refactor determinant method to create separate minor and cofactor
methods.
Add respective unit tests for new methods.
Rename methods using snake case to follow Python naming conventions.
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
86c03a8
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
72ada86
@tianyizheng02
Reorganize Vector and Matrix methods
3756b2f
@tianyizheng02 @poyea
Update linear_algebra/README.md
04a0845 
Co-authored-by: John Law <[email protected]>
@tianyizheng02
Fix punctuation and wording
53f9953
@tianyizheng02 @poyea
Apply suggestions from code review
f176b18 
Co-authored-by: John Law <[email protected]>
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
768bda8
@tianyizheng02
Deduplicate euclidean length method for Vector
36dd293
@tianyizheng02
Add more unit tests for Euclidean length method
6615be8
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
22af986
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Oct 29, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 29, 2021
poyea
poyea reviewed Oct 30, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove also Line 47

@tianyizheng02 tianyizheng02 requested a review from poyea October 31, 2021 00:51
poyea
poyea approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 31, 2021
@poyea poyea merged commit a64c9f1 into TheAlgorithms:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate Euclidean length method for Vector
2 participants
@tianyizheng02 @poyea