Skip to content

Rewrite parts of Vector and Matrix #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 27, 2021
Merged

Rewrite parts of Vector and Matrix #5362

merged 8 commits into from
Oct 27, 2021

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Oct 16, 2021 •
edited
Loading

Describe your change:

Rewrote parts of Vector and Matrix and added unit tests as needed

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 16, 2021
@tianyizheng02
Copy link
Contributor Author

tianyizheng02 commented Oct 16, 2021 •
edited
Loading

Also I noticed that Vector's euclidLength and magnitude methods both do the same thing. Should I open an issue to have one of them removed?

@tianyizheng02
Refactor determinant method and add unit tests
f84d769 
Refactor determinant method to create separate minor and cofactor
methods.
Add respective unit tests for new methods.
Rename methods using snake case to follow Python naming conventions.
@tianyizheng02 tianyizheng02 changed the title Rewrite parts of Vector and Matrix methods Rewrite parts of Vector and Matrix Oct 17, 2021
@tianyizheng02
Copy link
Contributor Author

I had to edit multiple files because I wrote unit tests for my new methods and renamed some existing methods

poyea
poyea reviewed Oct 19, 2021
View reviewed changes
@poyea poyea self-assigned this Oct 19, 2021
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 19, 2021
@poyea
Copy link
Member

poyea commented Oct 19, 2021

Also I noticed that Vector's euclidLength and magnitude methods both do the same thing. Should I open an issue to have one of them removed?

Let's keep euclidean_length. We can keep the tests of magnitude in euclidean_length

@poyea poyea linked an issue Oct 19, 2021 that may be closed by this pull request
Revamp Vector and Matrix classes #5396
Closed
poyea
poyea approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged for now. Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 27, 2021
@poyea poyea merged commit fe5c711 into TheAlgorithms:master Oct 27, 2021
@tianyizheng02 tianyizheng02 mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp Vector and Matrix classes
2 participants
@tianyizheng02 @poyea