Skip to content

Fixes #3359 #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 112 commits into from
Feb 28, 2023
Merged

Fixes #3359 #3873

merged 112 commits into from
Feb 28, 2023

Conversation

siddhant2002
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which algorithm is that?

@siriak
Copy link
Member

siriak commented Feb 14, 2023

image
File names are not in PascalCase

@siddhant2002
Copy link
Contributor Author

Which algorithm is that?

It displays all the paths from source to target

@siddhant2002
Copy link
Contributor Author

image File names are not in PascalCase

I've modified the file names

@siddhant2002
Copy link
Contributor Author

@siriak please check the updated pr

@siddhant2002
Copy link
Contributor Author

@siriak I've done the necessary changes. Please check the pr. The return type cannot be changed to int [ ][ ] as the junit are being used.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, please fix failing tests
Error: AllPathsFromSourceToTargetTest.testForFirstCase:18 iterable contents differ at index [0][0], expected: <0> but was: <2>
Error: AllPathsFromSourceToTargetTest.testForFourthcase:51 iterable contents differ at index [0][2], expected: <3> but was: <2>
Error: AllPathsFromSourceToTargetTest.testForThirdCase:40 iterable contents differ at index [0][0], expected: <0> but was: <1>

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit f361338 into TheAlgorithms:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants