Skip to content

MaximumSubArraySum #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MaximumSubArraySum #2877

wants to merge 1 commit into from

Conversation

Ayse-Sadioglu
Copy link

@Ayse-Sadioglu Ayse-Sadioglu commented Dec 12, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

siriak
siriak requested changes Dec 12, 2021
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add some tests as in https://github.com/TheAlgorithms/Java/pull/2871/files

src/main/java/com/thealgorithms/others/MaximumSubArraySum.java

// Finding maximum subarray sum for the left subarray

int leftMax = -1000000000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Integer.MIN_VALUE

src/main/java/com/thealgorithms/others/MaximumSubArraySum.java
}

// Find maximum subarray sum for the right subarray
int rightMax = -1000000000;//should be minimum value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

src/main/java/com/thealgorithms/others/MaximumSubArraySum.java

public class MaximumSubArraySum {
//Maximum Subarray Sum using Divide and Conquer algorithm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

src/main/java/com/thealgorithms/others/MaximumSubArraySum.java
Comment on lines +44 to +47
}


}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}
}
}

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 13, 2022
@siddhant2002
Copy link
Contributor

Can I work under this issue?

@siriak
Copy link
Member

siriak commented Jan 19, 2022

@siddhant2002 yes, feel free to implement this

@github-actions github-actions bot removed the stale label Jan 20, 2022
22aam
22aam reviewed Jan 26, 2022
View reviewed changes
Copy link

@22aam 22aam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good to me

@siddhant2002
Copy link
Contributor

@siriak please check the pr

@siriak
Copy link
Member

siriak commented Feb 10, 2022

@siddhant2002 which one? I've already reviewed this one

@siddhant2002
Copy link
Contributor

@siriak please check the updated pr

@siriak
Copy link
Member

siriak commented Feb 12, 2022

Superseded by #2913

@siriak siriak closed this Feb 12, 2022
siriak added a commit that referenced this pull request Feb 13, 2022
@siddhant2002 @siriak
Add tests for Kadane algorithm (#2877) (#2939)
0a062d4 
Co-authored-by: Andrii Siriak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@22aam 22aam 22aam left review comments

@siriak siriak siriak requested changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ayse-Sadioglu @siddhant2002 @siriak @22aam