Fixes(#2877) #2913
Closed
Fixes(#2877) #2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siriak please check the updated pr for maximum subarray sum |
siriak
requested changes
Jan 30, 2022
There was a problem hiding this comment.
Thanks for contributing, this algorithm is already present here https://github.com/TheAlgorithms/Java/blob/9fb3364cccc5373c32dbdb661f773c5ee753c77a/src/main/java/com/thealgorithms/dynamicprogramming/KadaneAlgorithm.java as far as I can tell, but the old implementation is missing tests, so your improvements are welcome. Could you consolidate your and existing implementations into one?
siriak
reviewed
Feb 12, 2022
Comment on lines
10
to
11
| int a[]={-1}; | ||
| assertTrue(KadaneAlgorithm.max_Sum(a)); |
There was a problem hiding this comment.
What does it mean? The purpose of the algorithm is to find the largest possible sum, why does it return bool?
There was a problem hiding this comment.
Basically it's checking with the predicted answer
|
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
|
亲，邮件已收到
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.