-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Added sort list Algorithm #2882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to include string compare algorithms, please replace main() with tests as in https://github.com/TheAlgorithms/Java/blob/98656cb0cdacd175559272bcbb8bc3b86ddac52a/src/test/java/com/thealgorithms/maths/KaprekarNumbersTest.java and improve formatting
@siriak Please check the updated pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting is much better, but you still need to replace main() with automated tests as mentioned in the previous review
@siriak Please check the updated pr |
ok
| |
张泓锐
|
|
***@***.***
|
签名由网易邮箱大师定制
在2022年01月19日 12:28,Siddhant Swarup ***@***.***> 写道:
@siriak Please check the updated pr
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}
.