Skip to content

DNM: Review Only - Add explicit ports #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

litghost
Copy link

@litghost litghost commented Dec 13, 2019

This PR adds a feature to enable explicit relationship between ports on a physical tile and the ports of the interior logical tile. This provides a way to solve part 1 of verilog-to-routing#1063

In a converstation with the VTR devs this is not a direction they want to go, but it is an expedient solution for the capacity issue f4pga/f4pga-arch-defs#1183 until the suggested method is added (stacks of physical tiles).

This PR is to get initial review on the explicit ports change, which will then be followed up with a wip/ branch, and a new master+wip PR.

Copy link
Collaborator

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
As far as I understood, with this patch, we need to add the information on the pin mapping to the pin_mapping of the equivalent site.

One thing I did not grasp is the following though. The IO of the physical tile are going to be all of them (e.g. in case of the BUFG all 16 instances) or only the reduced ones (input and output specified only once)?

@litghost
Copy link
Author

litghost commented Dec 13, 2019

we need to add the information on the pin mapping to the pin_mapping of the equivalent site.

Yes

One thing I did not grasp is the following though

The ports on the physical tiles need to be enough for all instances within the tile. Basically rather than specifying N pins and then duplicating them times capacity (total pins = N pins * N capacity), instead all tile pins must be explicitly specified. Then if the logical tiles have N logical pins, there must be at least total pins = N logical pins * N capacity, and that many direct specifications.

@litghost litghost closed this Dec 14, 2019
@litghost litghost deleted the add_explicit_ports branch June 24, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants