make better split between wrappers and torch implementations #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-br
force-pushed
the
infer-full-dtype-followup
branch
2 times, most recently
from
8f1b501 to
89a8d54
Compare
ev-br
force-pushed
the
move_to_impl
branch
6 times, most recently
from
963fb8c to
e304cc6
Compare
ev-br
force-pushed
the
move_to_impl
branch
2 times, most recently
from
707f4a4 to
f2ff966
Compare
ev-br
changed the title
|
This is no longer WIP, this is large enough. Nothing exciting here, this is pure MAINT PR, which sets the ground for a future work on communications between array_like user API and pytorch implementations. |
lezcano
reviewed
Feb 17, 2023
There was a problem hiding this comment.
Now that the implementations are much cleaner, I went on and re-reviewed the implementations of the functions.
Now, this starts to look much better! The implementationos in implementations.py are much cleaner and easier to understand, and then the ugly and repetitive preprocessing lives in _wrapper.py.
ev-br
force-pushed
the
move_to_impl
branch
2 times, most recently
from
5ec1278 to
fabf01f
Compare
Co-authored-by: Mario Lezcano Casado <[email protected]>
ev-br
force-pushed
the
move_to_impl
branch
2 times, most recently
from
13e5277 to
6970fd3
Compare
lezcano
approved these changes
Feb 19, 2023
lezcano
reviewed
Feb 19, 2023
lezcano
approved these changes
Feb 19, 2023
|
Thanks Mario for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards moving actual logic to
_detail, so that top level modules (currently, _wrappers.py, _ndarray.py) unwrap/normalize their inputs and pass heavy lifting to_detail. Details of organization of the_detailsubmodules are TBD, and so are details of unwrapping/normalization or arguments. This PR is to only to make the split as clean as reasonable.