MAINT: split tri* family

Author: ev-br

torch_np/_detail/implementations.py

@@ -82,6 +82,7 @@ def tensor_angle(z, deg=False):
 
 # ### sorting ###
 
+
 def tensor_argsort(tensor, axis=-1, kind=None, order=None):
     if order is not None:
         raise NotImplementedError
@@ -91,6 +92,45 @@ def tensor_argsort(tensor, axis=-1, kind=None, order=None):
     return torch.argsort(tensor, stable=stable, dim=axis, descending=False)
 
 
+# ### tri*-something ###
+
+
+def tri(N, M, k, dtype):
+    if M is None:
+        M = N
+    tensor = torch.ones((N, M), dtype=dtype)
+    tensor = torch.tril(tensor, diagonal=k)
+    return tensor
+
+
+def triu_indices_from(tensor, k):
+    if tensor.ndim != 2:
+        raise ValueError("input array must be 2-d")
+    result = torch.triu_indices(tensor.shape[0], arr.shape[1], offset=k)
+    return result
+
+
+def tril_indices_from(tensor, k=0):
+    if tensor.ndim != 2:
+        raise ValueError("input array must be 2-d")
+    result = torch.tril_indices(tensor.shape[0], tensor.shape[1], offset=k)
+    return result
+
+
+def tril_indices(n, k=0, m=None):
+    if m is None:
+        m = n
+    result = torch.tril_indices(n, m, offset=k)
+    return result
+
+
+def triu_indices(n, k=0, m=None):
+    if m is None:
+        m = n
+    result = torch.triu_indices(n, m, offset=k)
+    return result
+
+
 # ### splits ###
 
 

torch_np/_wrapper.py

@@ -706,44 +706,32 @@ def triu(m, k=0):
 
 
 def tril_indices(n, k=0, m=None):
-    if m is None:
-        m = n
-    tensor_2 = torch.tril_indices(n, m, offset=k)
-    return tuple(asarray(_) for _ in tensor_2)
+    result = _impl.tril_indices(n, k, m)
+    return tuple(asarray(t) for t in result)
 
 
 def triu_indices(n, k=0, m=None):
-    if m is None:
-        m = n
-    tensor_2 = torch.tril_indices(n, m, offset=k)
-    return tuple(asarray(_) for _ in tensor_2)
+    result = _impl.triu_indices(n, k, m)
+    return tuple(asarray(t) for t in result)
 
 
-# YYY: pattern: array in, sequence of arrays out
 def tril_indices_from(arr, k=0):
-    arr = asarray(arr).get()
-    if arr.ndim != 2:
-        raise ValueError("input array must be 2-d")
-    tensor_2 = torch.tril_indices(arr.shape[0], arr.shape[1], offset=k)
-    return tuple(asarray(_) for _ in tensor_2)
+    tensor = asarray(arr).get()
+    result = _impl.tril_indices_from(tensor, k)
+    return tuple(asarray(t) for t in result)
 
 
 def triu_indices_from(arr, k=0):
-    arr = asarray(arr).get()
-    if arr.ndim != 2:
-        raise ValueError("input array must be 2-d")
-    tensor_2 = torch.tril_indices(arr.shape[0], arr.shape[1], offset=k)
-    return tuple(asarray(_) for _ in tensor_2)
+    tensor = asarray(arr).get()
+    result = _impl.triu_indices_from(tensor, k)
+    return tuple(asarray(t) for t in result)
 
 
 @_decorators.dtype_to_torch
 def tri(N, M=None, k=0, dtype=float, *, like=None):
     _util.subok_not_ok(like)
-    if M is None:
-        M = N
-    tensor = torch.ones((N, M), dtype=dtype)
-    tensor = torch.tril(tensor, diagonal=k)
-    return asarray(tensor)
+    result = _impl.tri(N, M, k, dtype)
+    return asarray(result)
 
 
 ###### reductions