BUG: fix tolerance of real_if_close

Author: ev-br

torch_np/_detail/implementations.py

@@ -64,7 +64,13 @@ def real_if_close(x, tol=100):
     # XXX: copies vs views; numpy seems to return a copy?
     if not torch.is_complex(x):
         return x
-    mask = torch.abs(x.imag) < tol * torch.finfo(x.dtype).eps
+    if tol > 1:
+        # Undocumented in numpy: if tol < 1, it's an absolute tolerance!
+        # Otherwise, tol > 1 is relative tolerance, in units of the dtype epsilon
+        # https://github.com/numpy/numpy/blob/v1.24.0/numpy/lib/type_check.py#L577
+        tol = tol * torch.finfo(x.dtype).eps
+
+    mask = torch.abs(x.imag) < tol
     if mask.all():
         return x.real
     else:

torch_np/tests/numpy_tests/lib/test_type_check.py

@@ -82,7 +82,7 @@ def test_default_3(self):
         assert_equal(mintypecode('idD'), 'D')
 
 
-@pytest.mark.xfail(reason="not implemented")
+@pytest.mark.xfail(reason="TODO: decide on if [1] is a scalar or not")
 class TestIsscalar:
 
     def test_basic(self):
@@ -188,7 +188,6 @@ def test_isreal_real(self):
         assert res.all()
 
 
-@pytest.mark.xfail(reason="not implemented")
 class TestIscomplexobj:
 
     def test_basic(self):
@@ -206,7 +205,7 @@ def test_list(self):
         assert_(not iscomplexobj([3, 1, True]))
 
 
-@pytest.mark.xfail(reason="not implemented")
+
 class TestIsrealobj:
     def test_basic(self):
         z = np.array([-1, 0, 1])
@@ -215,7 +214,6 @@ def test_basic(self):
         assert_(not isrealobj(z))
 
 
-@pytest.mark.xfail(reason="not implemented")
 class TestIsnan:
 
     def test_goodvalues(self):
@@ -246,7 +244,6 @@ def test_complex1(self):
             assert_all(np.isnan(np.array(0+0j)/0.) == 1)
 
 
-@pytest.mark.xfail(reason="not implemented")
 class TestIsfinite:
     # Fixme, wrong place, isfinite now ufunc
 
@@ -278,7 +275,6 @@ def test_complex1(self):
             assert_all(np.isfinite(np.array(1+1j)/0.) == 0)
 
 
-@pytest.mark.xfail(reason="not implemented")
 class TestIsinf:
     # Fixme, wrong place, isinf now ufunc
 
@@ -308,7 +304,6 @@ def test_ind(self):
             assert_all(np.isinf(np.array((0.,))/0.) == 0)
 
 
-@pytest.mark.xfail(reason="not implemented")
 class TestIsposinf:
 
     def test_generic(self):
@@ -319,7 +314,6 @@ def test_generic(self):
         assert_(vals[2] == 1)
 
 
-@pytest.mark.xfail(reason="not implemented")
 class TestIsneginf:
 
     def test_generic(self):
@@ -436,7 +430,6 @@ def test_do_not_rewrite_previous_keyword(self):
         assert_equal(type(vals), np.ndarray)
 
 
-@pytest.mark.xfail(reason="not implemented")
 class TestRealIfClose:
 
     def test_basic(self):