Skip to content

Change storageUri to globalStorageUri for log and session files #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

andyleejordan
Copy link
Member

Instead of being workspace specific, as the extension itself is not. Also no chance of it being undefined.

Instead of being workspace specific, as the extension itself is not.
Also no chance of it being undefined.
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Logging labels Jul 26, 2022
@andyleejordan andyleejordan requested a review from a team July 26, 2022 15:35
@andyleejordan
Copy link
Member Author

Per #4067 (comment)

@andyleejordan andyleejordan enabled auto-merge (squash) July 26, 2022 16:39
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 47e3471 into main Jul 26, 2022
@andyleejordan andyleejordan deleted the andschwa/globalStorageUri branch July 26, 2022 17:32
@Tyriar Tyriar mentioned this pull request Aug 1, 2022
6 tasks
@GUO-CAI
Copy link

GUO-CAI commented Aug 3, 2022

桌面这个设计八卦的显示制
![1b61a4aa2e6019f5ae2efa3877aa3523](https://user-images.githubusercontent.com/8
QQ截图20220801191541
9382562/182513560-fd895329-c306-4c1f-b3e6-790d77ef5519.png)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants