Skip to content

No way to disable either move logs #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
irvnriir opened this issue Jul 11, 2022 · 14 comments
Closed
6 tasks done

No way to disable either move logs #4067

irvnriir opened this issue Jul 11, 2022 · 14 comments
Assignees
Labels
Area-Configuration Issue-Enhancement A feature request (enhancement). Resolution-Fixed Will close automatically.

Comments

@irvnriir
Copy link

irvnriir commented Jul 11, 2022

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

even "powershell.developer.editorServicesLogLevel": doesn't have a full disable option .

sometimes, for security, logs is required to not be kept in folders with executable files ,

i also periodically get this notification
Capture

i did the comparison, the only extension that gets modified is ms-vscode.powershell-<<..>> .

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.19041.1320
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}

Visual Studio Code Version

1.68.1
30d9c6cd9483b2cc586687151bcbcd635f373630
x64

Extension Version

Steps to Reproduce

get syntax errors in Powershell files

Visuals

No response

Logs

No response

@irvnriir irvnriir added the Issue-Bug A bug to squash. label Jul 11, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Jul 11, 2022
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Configuration and removed Issue-Bug A bug to squash. Needs: Triage Maintainer attention needed! labels Jul 11, 2022
@andyleejordan andyleejordan added the Resolution-Fixed Will close automatically. label Jul 19, 2022
@andyleejordan andyleejordan self-assigned this Jul 19, 2022
@andyleejordan
Copy link
Member

@irvnriir have you been able to test this in the preview?

@ghost ghost closed this as completed Jul 20, 2022
@ghost
Copy link

ghost commented Jul 20, 2022

This issue has been marked as fixed. It has been automatically closed for housekeeping purposes.

@irvnriir
Copy link
Author

irvnriir commented Jul 20, 2022

@andschwa nothing changed
Capture

@andyleejordan
Copy link
Member

@irvnriir did you clean that directory up, and can you test the new None option?

@andyleejordan
Copy link
Member

You have to have a workspace open for the workspace storage directory to be available for saving logs there.

@irvnriir
Copy link
Author

irvnriir commented Jul 20, 2022

@andschwa there is no none option . one present in powershell.pester.debugOutputVerbosity , but not powershell.developer.editorServicesLogLevel .

@irvnriir
Copy link
Author

irvnriir commented Jul 20, 2022

check whether the version at screenshot (the only available) is the one including the update .

@andyleejordan
Copy link
Member

😬 I thought I'd included it in the last preview, it was not. I'll ping you when the next one is out 😅

@andyleejordan
Copy link
Member

Hey @irvnriir I just released v2022.7.1-preview, with this fix! Can you test it out and verify for me? Let me know if you find anything else being written to the extension installation directory instead of the workspace storage!

@irvnriir
Copy link
Author

irvnriir commented Jul 26, 2022

seems working . though its very wrong that it saves logs to Workspace Storage and not globalStorage .

how you expect logs that are no longer relevant be cleared ?

@andyleejordan
Copy link
Member

...I swear I was pointed at workspace storage as the correct place to put them. Moving to global storage.

how you expect logs that are no longer relevant be cleared ?

IDK, what's the current behavior?

@irvnriir
Copy link
Author

irvnriir commented Jul 26, 2022

well, i didn't point there, i pointed "userfiles" -- (global) .

IDK, what's the current behavior?

(the issue appears if you choose the W. Storage)

@andyleejordan
Copy link
Member

I'm sorry, I don't understand your reply. Can you try again?

@irvnriir
Copy link
Author

irvnriir commented Jul 26, 2022

leave it, all s fine since

Moving to global storage.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Configuration Issue-Enhancement A feature request (enhancement). Resolution-Fixed Will close automatically.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants