Skip to content

Don't notify the user about updates #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 6 tasks
Tyriar opened this issue Aug 1, 2022 · 7 comments · Fixed by #4105
Closed
2 of 6 tasks

Don't notify the user about updates #4100

Tyriar opened this issue Aug 1, 2022 · 7 comments · Fixed by #4105
Labels
Area-UI Feature: VS Code Request to use or implement a VS Code feature. Issue-Enhancement A feature request (enhancement).

Comments

@Tyriar
Copy link
Contributor

Tyriar commented Aug 1, 2022

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

We are trying to reduce "notification fatigue" and this one seems very much not useful:

Screen Shot 2022-07-31 at 5 13 57 pm

The update's content was:

Which definitely doesn't seem important enough to interrupt the user. Also consider if all of a user's extensions do this they could be getting 1+ notifications a day on average? Some users have over 100 extensions installed based on issues we've seen.

This is the VS Code issue tracking a generic extension has updated announcement microsoft/vscode#123906

PowerShell Version

-

Visual Studio Code Version

Version: 1.70.0-insider
Commit: 12b08be500f8a307f30e92cbc3ee39ba115eab69
Date: 2022-07-29T10:50:40.282Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Darwin x64 21.6.0

Extension Version

Steps to Reproduce

Wait for an update with auto updates on

Visuals

No response

Logs

No response

@Tyriar Tyriar added the Issue-Bug A bug to squash. label Aug 1, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Aug 1, 2022
@andyleejordan
Copy link
Member

To be fair, that's the preview extension you're seeing an update for. The changelog for the one stable release rolled out last month was much longer.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Feature: VS Code Request to use or implement a VS Code feature. Area-UI and removed Issue-Bug A bug to squash. Needs: Triage Maintainer attention needed! labels Aug 1, 2022
@Tyriar
Copy link
Contributor Author

Tyriar commented Aug 1, 2022

Personally I don't like any extensions doing this even on stable, but VS Code Insiders for example only pops up the release notes webview when a major insiders version change happens

@andyleejordan
Copy link
Member

Yeah it's a reasonable ask, I don't like extra noise either. And the ideal situation is that the extension always "just works" and gets better in the background.

@SeeminglyScience
Copy link
Collaborator

I agree that it'd be better if we kept the notification to large changes. Even ignoring the fact that it can be annoying, the more folks click Show Release Notes and it's a small change the less likely they are to click that button next time.

Also a "Don't show again" button might be advisable.

@andyleejordan
Copy link
Member

I doubt anyone would miss it if we turned it off.

@fflaten
Copy link
Contributor

fflaten commented Aug 2, 2022

If/when there are new user-facing features and documented like VSCode release notes, then it would be nice to get a notification. With the current issue-list format, its probably not necessary.

@Tyriar
Copy link
Contributor Author

Tyriar commented Aug 4, 2022

Thanks @andschwa 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Feature: VS Code Request to use or implement a VS Code feature. Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants