Skip to content

Deprecate promptToUpdatePackageManagement #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SeeminglyScience
Copy link
Collaborator

Fixes #3858

PR Summary

Deprecate the promptToUpdatePackageManagement setting as it's no longer required with the new PSES architecture.

Also add deprecation messages to other clearly intended to be deprecated settings.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • [NA] PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Fixes PowerShell#3858
Also add deprecation messages to other previously deprecated settings
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the related code in settings.ts too?

promptToUpdatePackageManagement:
configuration.get<boolean>("promptToUpdatePackageManagement", true),

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some removals.

@andyleejordan andyleejordan enabled auto-merge (squash) March 10, 2022 20:55
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Configuration labels Mar 10, 2022
@andyleejordan andyleejordan merged commit 12dcd2d into PowerShell:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Configuration Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deprecate powershell.promptToUpdatePackageManagement setting
2 participants