Skip to content

Deprecate promptToUpdatePackageManagement #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Deprecate promptToUpdatePackageManagement #3859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2190690
Deprecate `promptToUpdatePackageManagement`
SeeminglyScience Mar 1, 2022
4c62c17
Remove from settings.ts as well
SeeminglyScience Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,8 @@
"type": "string",
"default": "",
"scope": "machine",
"description": "REMOVED. Please use the \"powershell.powerShellDefaultVersion\" setting instead."
"description": "REMOVED. Please use the \"powershell.powerShellDefaultVersion\" setting instead.",
"deprecationMessage": "Please use the \"powershell.powerShellDefaultVersion\" setting instead."
},
"powershell.promptToUpdatePowerShell": {
"type": "boolean",
Expand All @@ -604,7 +605,8 @@
"powershell.promptToUpdatePackageManagement": {
"type": "boolean",
"description": "Specifies whether you should be prompted to update your version of PackageManagement if it's under 1.4.6.",
"default": true
"default": true,
"deprecationMessage": "This prompt has been removed as it's no longer strictly necessary to upgrade the PackageManagement module."
},
"powershell.startAsLoginShell.osx": {
"type": "boolean",
Expand Down Expand Up @@ -746,7 +748,8 @@
"powershell.codeFormatting.whitespaceAroundPipe": {
"type": "boolean",
"default": true,
"description": "REMOVED. Please use the \"powershell.codeFormatting.addWhitespaceAroundPipe\" setting instead. If you've used this setting before, we have moved it for you automatically."
"description": "REMOVED. Please use the \"powershell.codeFormatting.addWhitespaceAroundPipe\" setting instead. If you've used this setting before, we have moved it for you automatically.",
"deprecationMessage": "Please use the \"powershell.codeFormatting.addWhitespaceAroundPipe\" setting instead. If you've used this setting before, we have moved it for you automatically."
},
"powershell.codeFormatting.addWhitespaceAroundPipe": {
"type": "boolean",
Expand Down
3 changes: 0 additions & 3 deletions src/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ export interface ISettings {
// This setting is no longer used but is here to assist in cleaning up the users settings.
powerShellExePath?: string;
promptToUpdatePowerShell?: boolean;
promptToUpdatePackageManagement?: boolean;
bundledModulesPath?: string;
startAsLoginShell?: IStartAsLoginShellSettings;
startAutomatically?: boolean;
Expand Down Expand Up @@ -233,8 +232,6 @@ export function load(): ISettings {
configuration.get<string>("powerShellExePath", undefined),
promptToUpdatePowerShell:
configuration.get<boolean>("promptToUpdatePowerShell", true),
promptToUpdatePackageManagement:
configuration.get<boolean>("promptToUpdatePackageManagement", true),
bundledModulesPath:
"../modules", // Because the extension is always at `<root>/out/main.js`
useX86Host:
Expand Down