Skip to content

Commit 12dcd2d

Browse files
authoredMar 10, 2022
Deprecate promptToUpdatePackageManagement (#3859)
Also add deprecation messages to other previously deprecated settings. Fixes #3858
1 parent cc2c6eb commit 12dcd2d

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed
 

‎package.json

+6-3
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,8 @@
579579
"type": "string",
580580
"default": "",
581581
"scope": "machine",
582-
"description": "REMOVED. Please use the \"powershell.powerShellDefaultVersion\" setting instead."
582+
"description": "REMOVED. Please use the \"powershell.powerShellDefaultVersion\" setting instead.",
583+
"deprecationMessage": "Please use the \"powershell.powerShellDefaultVersion\" setting instead."
583584
},
584585
"powershell.promptToUpdatePowerShell": {
585586
"type": "boolean",
@@ -589,7 +590,8 @@
589590
"powershell.promptToUpdatePackageManagement": {
590591
"type": "boolean",
591592
"description": "Specifies whether you should be prompted to update your version of PackageManagement if it's under 1.4.6.",
592-
"default": true
593+
"default": true,
594+
"deprecationMessage": "This prompt has been removed as it's no longer strictly necessary to upgrade the PackageManagement module."
593595
},
594596
"powershell.startAsLoginShell.osx": {
595597
"type": "boolean",
@@ -731,7 +733,8 @@
731733
"powershell.codeFormatting.whitespaceAroundPipe": {
732734
"type": "boolean",
733735
"default": true,
734-
"description": "REMOVED. Please use the \"powershell.codeFormatting.addWhitespaceAroundPipe\" setting instead. If you've used this setting before, we have moved it for you automatically."
736+
"description": "REMOVED. Please use the \"powershell.codeFormatting.addWhitespaceAroundPipe\" setting instead. If you've used this setting before, we have moved it for you automatically.",
737+
"deprecationMessage": "Please use the \"powershell.codeFormatting.addWhitespaceAroundPipe\" setting instead. If you've used this setting before, we have moved it for you automatically."
735738
},
736739
"powershell.codeFormatting.addWhitespaceAroundPipe": {
737740
"type": "boolean",

‎src/settings.ts

-3
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ export interface ISettings {
8484
// This setting is no longer used but is here to assist in cleaning up the users settings.
8585
powerShellExePath?: string;
8686
promptToUpdatePowerShell?: boolean;
87-
promptToUpdatePackageManagement?: boolean;
8887
bundledModulesPath?: string;
8988
startAsLoginShell?: IStartAsLoginShellSettings;
9089
startAutomatically?: boolean;
@@ -233,8 +232,6 @@ export function load(): ISettings {
233232
configuration.get<string>("powerShellExePath", undefined),
234233
promptToUpdatePowerShell:
235234
configuration.get<boolean>("promptToUpdatePowerShell", true),
236-
promptToUpdatePackageManagement:
237-
configuration.get<boolean>("promptToUpdatePackageManagement", true),
238235
bundledModulesPath:
239236
"../modules", // Because the extension is always at `<root>/out/main.js`
240237
useX86Host:

0 commit comments

Comments
 (0)