Skip to content

The "tags" in a CompletionItem response should be an array, not null #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwols opened this issue Jul 8, 2020 · 3 comments · Fixed by OmniSharp/csharp-language-server-protocol#258
Closed

The "tags" in a CompletionItem response should be an array, not null #1325

rwols opened this issue Jul 8, 2020 · 3 comments · Fixed by OmniSharp/csharp-language-server-protocol#258
Labels
Area-Language Server Issue-Bug A bug to squash.

Comments

@rwols
Copy link

rwols commented Jul 8, 2020

I'm noticing that the "tags" of a completion item is null, but this violates the spec. You should leave the key out altogether if there are no tags.
@ghost ghost added the Needs: Triage Maintainer attention needed! label Jul 8, 2020
@TylerLeonhardt
Copy link
Member

I think this just needs to be marked optional:

https://github.com/OmniSharp/csharp-language-server-protocol/blob/bdec4c73240be52fbb25a81f6ad7d409f77b5215/src/Protocol/Models/CompletionItem.cs#L25-L30

this is really a bug in csharp-language-server-protocol I think. cc @david-driscoll

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jul 8, 2020
rwols added a commit to sublimelsp/LSP that referenced this issue Jul 9, 2020
@rwols @predragnikolic
Work around spec bugs for PowerShellEditorServices (#1181)
353c942 
- The "tags" in a CompletionItem response are null (invalid per spec)
- The "signatures" in a textDocument/signatureHelp response is null (invalid per spec)

See: PowerShell/PowerShellEditorServices#1324
See: PowerShell/PowerShellEditorServices#1325

Co-authored-by: Предраг Николић / Predrag Nikolic <[email protected]>
@SydneyhSmith SydneyhSmith added Area-Language Server Issue-Bug A bug to squash. and removed Needs: Maintainer Attention Maintainer attention needed! Needs: Triage Maintainer attention needed! labels Jul 9, 2020
@TylerLeonhardt TylerLeonhardt mentioned this issue Jul 9, 2020
Merged
@TylerLeonhardt
Copy link
Member

fix out for this ^

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jul 9, 2020
@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Jul 9, 2020
@TylerLeonhardt
Copy link
Member

This is fixed. Automation will rev the version of the library that we use and it'll be in the next version of PSES

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jul 9, 2020
@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Language Server Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SignatureHelp and CompletionItem spec fix TylerLeonhardt/csharp-language-server-protocol
3 participants
@rwols @TylerLeonhardt @SydneyhSmith