The response to textDocument/signatureHelp is not per spec

[rwols]

:: --> PowerShellEditorServices textDocument/signatureHelp(7): {'position': {'line': 0, 'character': 8}, 'textDocument': {'uri': 'file:///Users/raoulwols/Library/Application%20Support/Sublime%20Text%203/Packages/LSP-PowerShellEditorServices/test.ps1'}}
:: <<< PowerShellEditorServices 7: {'signatures': None}

The value of the signatures key should be an array (so not an array | null).
If there are no signatures available, you can send null instead of {"signatures": null}.

[TylerLeonhardt]

Looks like this is the line where we're doing it wrong:

PowerShellEditorServices/src/PowerShellEditorServices/Services/TextDocument/Handlers/SignatureHelpHandler.cs

Lines 68 to 71 in fdb2095

	if (parameterSets == null)
	{
	return new SignatureHelp();
	}

I guess we can just return null... although... maybe new SignatureHelp() should create an empty array for Signatures...

cc @david-driscoll

[TylerLeonhardt]

btw @rwols what client are you using?

[rwols]

I'm using this plugin for SublimeText. I'm actually working on a convenience plugin that installs/updates the server here.

[rwols]

maybe new SignatureHelp() should create an empty array for Signatures...

That is certainly also a possibility.

[TylerLeonhardt]

@rwols if you want to contribute a call out to LSP-PowerShellEditorServices in our README that'd be awesome :)

[TylerLeonhardt]

fix out for this ^

[TylerLeonhardt]

This is fixed. Automation will rev the version of the library that we use and it'll be in the next version of PSES

[rwols]

Thanks for the quick fix! I'm still busy getting things working for Windows, I'll make a PR for a call-out when the plugin is ready :)