Skip to content

SignatureHelp and CompletionItem spec fix #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TylerLeonhardt
Copy link
Collaborator

Fixes PowerShell/PowerShellEditorServices#1324
Fixes PowerShell/PowerShellEditorServices#1325

Tags on CompletionItem should be optional and
Signatures on SignatureHelp should not be null

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #258 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   62.06%   62.07%           
=======================================
  Files         383      384    +1     
  Lines       11489    11490    +1     
  Branches     1361     1361           
=======================================
+ Hits         7131     7132    +1     
  Misses       3788     3788           
  Partials      570      570           
Impacted Files Coverage Δ
src/Protocol/Models/SignatureHelp.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82ff82...b9802ba. Read the comment docs.

@david-driscoll david-driscoll merged commit dca32a6 into OmniSharp:master Jul 9, 2020
@david-driscoll david-driscoll added the bug Something isn't working label Jul 9, 2020
@TylerLeonhardt TylerLeonhardt deleted the signature-help-completion-item-tags-spec-fix branch July 9, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants