Skip to content

chore: merge release into master #5206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 10, 2020
Merged

chore: merge release into master #5206

merged 16 commits into from
Jan 10, 2020

Conversation

DimitarTachev
Copy link
Contributor

No description provided.

DimitarTachev and others added 16 commits December 17, 2019 11:24
Currently the `tns info` command fails when executed inside application in which `tns-core-modules` package is not available as dependency. This may happen in case you use only `@nativescript/core` package.
The problem is that CLI is trying to read the package.json of the `<project dir>/node_modules/tns-core-modules` and this operation fails.
To fix this, add checks for both `tns-core-modules` and `@nativescript/core` packages. Warnings/information will be shown only for the package used in package.json, i.e. in case you use `tns-core-modules`, we'll show information only for it.
…oped-package

fix: `tns info` should work with scoped modules
In case you have emulator with API Level 29 and other older emulators, CLI should run the latest available (29), but it doesn't.
The problem is in the parsing of the string version - '9.0.0' is always newer than '10.0.0' which corresponds to API level 29. Fix the parsing, so now `tns run android` will correctly start latest available emulator in case there's nothing running.
…-start

fix: emulator 29 is not started by default
feat: expose before build hooks in order to support cloud builds without an extension
@cla-bot cla-bot bot added the cla: yes label Jan 10, 2020
@DimitarTachev DimitarTachev merged commit c71fbf9 into master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants