fix: tns info should work with scoped modules
#5198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `tns info` command fails when executed inside application in which `tns-core-modules` package is not available as dependency. This may happen in case you use only `@nativescript/core` package. The problem is that CLI is trying to read the package.json of the `<project dir>/node_modules/tns-core-modules` and this operation fails. To fix this, add checks for both `tns-core-modules` and `@nativescript/core` packages. Warnings/information will be shown only for the package used in package.json, i.e. in case you use `tns-core-modules`, we'll show information only for it.
|
test cli-misc |
DimitarTachev
approved these changes
Jan 6, 2020
|
test cli-misc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
tns infocommand fails when executed inside application in whichtns-core-modulespackage is not available as dependency. This may happen in case you use only@nativescript/corepackage.The problem is that CLI is trying to read the package.json of the
<project dir>/node_modules/tns-core-modulesand this operation fails.To fix this, add checks for both
tns-core-modulesand@nativescript/corepackages. Warnings/information will be shown only for the package used in package.json, i.e. in case you usetns-core-modules, we'll show information only for it.PR Checklist
What is the current behavior?
tns infofails when executed in a project withouttns-core-modulesin it.What is the new behavior?
tns infosucceeds when executed in a project withouttns-core-modulesin it.Fixes issue #5192