fix: emulator 29 is not started by default #5201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test cli-smoke cli-run |
In case you have emulator with API Level 29 and other older emulators, CLI should run the latest available (29), but it doesn't. The problem is in the parsing of the string version - '9.0.0' is always newer than '10.0.0' which corresponds to API level 29. Fix the parsing, so now `tns run android` will correctly start latest available emulator in case there's nothing running.
rosen-vladimirov
force-pushed
the
vladimirov/fix-emulator-29-start
branch
from
71bde81 to
a360ba2
Compare
|
test cli-smoke cli-run |
DimitarTachev
approved these changes
Jan 9, 2020
|
Actual build result (after resume) is here. It's green, so I'm merging the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you have emulator with API Level 29 and other older emulators, CLI should run the latest available (29), but it doesn't.
The problem is in the parsing of the string version - '9.0.0' is always newer than '10.0.0' which corresponds to API level 29. Fix the parsing, so now
tns run androidwill correctly start latest available emulator in case there's nothing running.PR Checklist
What is the current behavior?
What is the new behavior?
Fixes issue #5200