chore: merge release in master #4204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate-fail Kddimitrov/handle plugin create fail
In case when some `.js` file is changed, preview app is restarted on device e.g preview app is stopped and started again. When the preview app is stopped, Pubnub reports the device as lost and when preview app is started, Pubnub reports the device as found. With this fix, we want to delay the emitting of deviceLost event. This way we'll give a chance to find the device before reporting it as lost.
When stopLiveSync method is called, we want to reset devices list and receive deviceLost event for all connected devices.
…meout fix(preview-api): raise deviceLost event after timeout of 5 seconds
…p-livesync fix: reset devices list when stopLiveSync method is called
fix: reset deviceLostTimer after clearing the device's timeout
…rown while livesyncing to preview app
…ents in `PublicAPI.md`
Docs for the public api for preview
…-error feat(preview-api): emit previewAppLiveSyncError when some error is thrown while livesyncing to preview app
Reset prepare info when native platform status is not alreadyPrepared in order to ensure the project will be prepared and all properties of this._prepareInfo will be correctly populated.
…r-cloud fix: execute correctly local build after cloud build from sidekick
chore: changelog for 5.0.2 release
Sometimes we have sporadically stuck http requests/responses and in those cases the CLI is just waiting and not doing anything. If we retry the requests, they will pass. That's why we need to add a retry logic in the http client.
fix: retry stuck requests/responses
fix: update nativescript-preview-sdk version to 0.3.1 and cli's version to 5.0.3
chore: add changelog for 5.0.3 release
Fatme
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].