fix(preview-api): raise deviceLost event after timeout of 5 seconds #4150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case when some `.js` file is changed, preview app is restarted on device e.g preview app is stopped and started again. When the preview app is stopped, Pubnub reports the device as lost and when preview app is started, Pubnub reports the device as found. With this fix, we want to delay the emitting of deviceLost event. This way we'll give a chance to find the device before reporting it as lost.
DimitarTachev
approved these changes
Nov 20, 2018
| @@ -4,6 +4,7 @@ import { DeviceDiscoveryEventNames, DEVICE_LOG_EVENT_NAME } from "../../../../co | |||
|
|
|||
| export class PreviewDevicesService extends EventEmitter implements IPreviewDevicesService { | |||
| private connectedDevices: Device[] = []; | |||
| private deviceTimers: IDictionary<NodeJS.Timer> = {}; | |||
There was a problem hiding this comment.
deviceTimers -> deviceLostTimers
| if (this.deviceTimers[device.id]) { | ||
| clearTimeout(this.deviceTimers[device.id]); | ||
| } | ||
|
|
||
| this.emit(DeviceDiscoveryEventNames.DEVICE_FOUND, device); |
There was a problem hiding this comment.
Shouldn't this be in else (we could also add a test for such case)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when some
.jsfile is changed, preview app is restarted on device e.g preview app is stopped and started again. When the preview app is stopped, Pubnub reports the device as lost and when preview app is started, Pubnub reports the device as found. With this fix, we want to delay the emitting of deviceLost event. This way we'll give a chance to find the device before reporting it as lost.PR Checklist