Kddimitrov/handle plugin create fail #4144

KristianDD · 2018-11-19T16:16:37Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Tests for the changes are included.

See issue

Cleanups plugin folder every time the command fails

Fixes/Implements/Closes #3962

KristianDD added 2 commits November 19, 2018 14:30

fix: plugin create doesn't always clean up folder if execution fails

2b9bd70

test: add tests for plugin dir removal

57b1631

KristianDD force-pushed the kddimitrov/handle-plugin-create-fail branch from bf2c3a6 to 57b1631 Compare November 19, 2018 16:23

DimitarTachev approved these changes Nov 19, 2018

View reviewed changes

KristianDD merged commit 123206b into release Nov 19, 2018

KristianDD deleted the kddimitrov/handle-plugin-create-fail branch November 19, 2018 17:00