Skip to content

Merge release into master #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Nov 19, 2018
Merged

Conversation

DimitarTachev
Copy link
Contributor

No description provided.

Fatme and others added 23 commits November 8, 2018 00:26
…interface

Release option does not make sense in the context of the preview app
fix: fix project creation with github url passed as template
Chokidar 1.7.0, which we are currently using, is unable to watch directories with names that contain glob symbols (like `(`, `*`, etc.). There are two ways to fix this:
 - pass `disableGlobbing: true`, so all paths will be treated as strings.
 - update chokidar to latest version, where the issue is fixed

Suggested solution is to update chokidar to latest version, so we'll get all other fixes listed [here](https://github.com/paulmillr/chokidar/blob/master/CHANGELOG.md)
fix(deps): update chokidar, so we can watch dirs with `(`
fix(preview-api): remove mandatory release option from IPreviewAppLiveSyncData interface
feat(preview-api): expose api for getting logs from preview app
…arnings

feat(preview-api): expose public api for getting device's warnings
…us-on-add-platform

fix: store the platform status on `platform add` in order to avoid another platform add during `prepare`.
@DimitarTachev DimitarTachev merged commit 2df4c2c into master Nov 19, 2018
@DimitarTachev DimitarTachev deleted the tachev/merge-release-into-master branch November 19, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants