-
-
Notifications
You must be signed in to change notification settings - Fork 197
Merge release into master #4143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface Release option does not make sense in the context of the preview app
fix: fix project creation with github url passed as template
Chokidar 1.7.0, which we are currently using, is unable to watch directories with names that contain glob symbols (like `(`, `*`, etc.). There are two ways to fix this: - pass `disableGlobbing: true`, so all paths will be treated as strings. - update chokidar to latest version, where the issue is fixed Suggested solution is to update chokidar to latest version, so we'll get all other fixes listed [here](https://github.com/paulmillr/chokidar/blob/master/CHANGELOG.md)
release: update CHANGELOG for 5.0.1
chore: bump version to 5.0.2
fix(deps): update chokidar, so we can watch dirs with `(`
fix(preview-api): remove mandatory release option from IPreviewAppLiveSyncData interface
feat(preview-api): expose api for getting logs from preview app
…arnings feat(preview-api): expose public api for getting device's warnings
…other platform add during `prepare`.
…us-on-add-platform fix: store the platform status on `platform add` in order to avoid another platform add during `prepare`.
rosen-vladimirov
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.