feat(preview-api): expose public api for getting device's warnings #4132

Fatme · 2018-11-14T07:03:49Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Tests for the changes are included.

No api for getting warnings from device

const deviceWarnings = tns.previewDevicesService.getDeviceWarnings({ previewAppVersion: "19.0.0" });
console.log(deviceWarnings);

DimitarTachev · 2018-11-14T13:08:15Z

lib/services/livesync/playground/preview-app-plugins-service.ts

 		private $logger: ILogger,
 		private $pluginsService: IPluginsService) { }

+	public getDeviceWarnings(device: Device): string[] {


I don't expect getDeviceWarnings in PreviewAppPluginsService. It doesn't look like a plugins related logic.

Fatme force-pushed the fatme/preview-api-device-warnings branch from 25d3c6f to 2cb69c9 Compare November 14, 2018 07:17

DimitarTachev suggested changes Nov 14, 2018

View reviewed changes

DimitarTachev approved these changes Nov 15, 2018

View reviewed changes

Fatme added 3 commits November 16, 2018 08:30

feat(preview-api): expose public api for getting device's warnings

37f2696

chore: fix unit tests

662d56c

chore: fix PR comments

b3bc007

Fatme force-pushed the fatme/preview-api-device-warnings branch from 82de7a6 to b3bc007 Compare November 16, 2018 06:33

Fatme merged commit 986673d into release Nov 16, 2018

Fatme deleted the fatme/preview-api-device-warnings branch November 16, 2018 07:47