Skip to content

fix(preview-api): remove mandatory release option from IPreviewAppLiveSyncData interface #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Nov 7, 2018

Release option does not make sense in the context of the preview app so it should be deleted from public api for livesync to preview app.

PR Checklist

What is the current behavior?

tns.liveSyncService.liveSyncToPreviewApp({
    projectDir: "myProjectDir",
    appFilesUpdaterOptions: {
        bundle: false,
        release: false,
        useHotModuleReload: false   
    },
    env: {}
});

What is the new behavior?

tns.liveSyncService.liveSyncToPreviewApp({
    projectDir: "myProjectDir",
    bundle: false,
    useHotModuleReload: false,
    env: {}
});

This way the api will be consisted with

tns.liveSyncService.liveSync(deviceDescriptors, {
    projectDir: "myProjectDir",
    bundle: false,
    useHotModuleReload: false,
    env: {},
    ....
});

Fatme added 2 commits November 8, 2018 00:26
…interface

Release option does not make sense in the context of the preview app
Copy link
Contributor

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a block for the 5.0.1 freeze

Copy link
Contributor

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create an issue in order to move it to RFT

@Fatme Fatme merged commit bc32b6b into release Nov 14, 2018
@Fatme Fatme deleted the fatme/remove-release-preview branch November 14, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants