chore: Merge release in master #3627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide of project directory
…uted and env is not correctly configured.
Fix issue with C++ source code files being added to Resources instead of Sources group. Add unit tests.
…pp-group fix(node-xcode): Update to 1.5.1 tag
After upgrading `nativescript-doctor`, the version of the Java is validated against the current Android runtime version. In case the runtime version cannot work with Java 10, `nativescript-doctor` does not allow the operation to continue. This breaks the `platform remove` command, as it checks the system requirements first, before executing the actual removal. However, this is no longer required as the code for removing the platform is `try-catched` and in case the current environment is not setup correctly, it will try to remove the platforms/<platform> dir and the respective key in package.json. So remove the environment validation from this command. Also remove the `validatePlatformInstalled` call from the `canExecute` method of the command, as it is actually called in the `removePlatforms` method.
…move fix: platform remove command fails with old Android runtime
Add logic to validate environment based on the specified runtime version. This is required for the cases where the runtime version is not specified in the project's package.json but we need to verify if a runtime version can be used For `tns platform update <platform>` command validate the runtime version that will be installed based on the passed argument. This has two cases: 1. In case version is specified: `tns platform update [email protected]` - we'll get the 4.0.1 version and validate if it can be used with currently installed Java compiler version. 2. In case version is not specified: `tns platform update android` - we'll not validate the java version here as we know we'll install at least 4.1.0 runtime, which is compatible with all Java versions For `tns platform clean <platform>` command we need to validate the current platform immediately as the command removes it and adds the same version after that.
…mmands fix: platform update/clean commands may fail with Java 10
Natalia-Hristova
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest changes from release in master