Skip to content

Fix doctor #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2018
Merged

Fix doctor #3618

merged 2 commits into from
May 25, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented May 25, 2018

Don't show components info when tns doctor command is executed outside of project directory. Don't print warning twice when tns doctor command is executed and env is not properly configured.

In case when some issues are detected, checkEnvironmentRequirements prints the detected warnings. (actually canExecuteLocalBuilds print them). In case when no issues are found, we need to print them from printWarnings method.

PR Checklist

@Fatme Fatme added this to the 4.1.0 milestone May 25, 2018
@Fatme Fatme changed the title Fatme/fix doctor Fix doctor May 25, 2018
@rosen-vladimirov
Copy link
Contributor

run ci

@rosen-vladimirov rosen-vladimirov changed the base branch from master to release May 25, 2018 16:52
@Fatme Fatme merged commit 255bd92 into release May 25, 2018
@Fatme Fatme deleted the fatme/fix-doctor branch May 25, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants