fix: platform update/clean commands may fail with Java 10 #3626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to validate environment based on the specified runtime version. This is required for the cases where the runtime version is not specified in the project's package.json but we need to verify if a runtime version can be used For `tns platform update <platform>` command validate the runtime version that will be installed based on the passed argument. This has two cases: 1. In case version is specified: `tns platform update [email protected]` - we'll get the 4.0.1 version and validate if it can be used with currently installed Java compiler version. 2. In case version is not specified: `tns platform update android` - we'll not validate the java version here as we know we'll install at least 4.1.0 runtime, which is compatible with all Java versions For `tns platform clean <platform>` command we need to validate the current platform immediately as the command removes it and adds the same version after that.
|
run ci |
1 similar comment
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to validate environment based on the specified runtime version. This is required for the cases where the runtime version is not specified in the project's package.json but we need to verify if a runtime version can be used
For
tns platform update <platform>command validate the runtime version that will be installed based on the passed argument. This has two cases:tns platform update [email protected]- we'll get the 4.0.1 version and validate if it can be used with currently installed Java compiler version.tns platform update android- we'll not validate the java version here as we know we'll install at least 4.1.0 runtime, which is compatible with all Java versionsFor
tns platform clean <platform>command we need to validate the current platform immediately as the command removes it and adds the same version after that.Depends on: NativeScript/nativescript-doctor#37 and telerik/mobile-cli-lib#1096