chore: Merge release in master #3569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the usage reporting is disabled, the verbose log of CLI still prints that will send information to Google Analytics. In fact it does not do it. The problem is that the message is printed before checking the state of the usage reporting. Fix this by placing the printing in the correct method.
fix(analytics): Message for tracking in GA is always printed
Expose the `getAppProcessId` method from `androidProcessService`, so it can be called when using CLI as a library.
…process-service feat(API): Expose androidProcessService - getAppProcessId
…s-sim Update common lib and ios-sim version
Add support for Node.js 10.x.x. Currently, when trying to use CLI with Node.js 10.x.x, error is thrown. The problem is that we are using npm-shrinkwrap.json to keep using same versions of all dependencies, no matter how they are defined in the package.json files. The current problem is that the `unzip` package relies on `fstream` package, which depends on `graceful-fs` 3.0.11 version. This version of `graceful-fs` depends on `natives` package by using the range `^1.1.0`. In our `npm-shrinkwrap.json` this range is resolved to version 1.1.2. This version of the `natives` package does not work with Node.js 10.x.x. There's a newer one - 1.1.3 that fixes it. So the solution is to update the npm-shrinkwrap.json and use the latest version of `natives` package. Also add version 10.x.x as supported in CLI's package.json, so we'll not show warning that it is not validated.
fix: Support Node.js 10.x.x
…ssing In case you delete `App_Resources/iOS` directory, the `getAssetsStructure` method fails as it tries to read `Content.json` files from the deleted directory. Instead of failing, just return empty arrays for the images. This is already working this way for Android. Add test for the case
…cture fix(assets-generation): Do not fail in case some App_Resources are missing
In case the path to project has space in the name and there's Android plugin that should be build, the build operation fails. The reason is usage of exec - change it to spawn, which handles the spaces correctly. feat: Add `buildAndroidPlugin` hook, which is executed just before spawning the gradle build for specific plugin. The hook can be used to modify plugin's structure before building the plugin.
fix: Build plugins when path to project has space
…and-sdk Add docs for device name and sdk options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge release in master