fix: Support Node.js 10.x.x #3556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Node.js 10.x.x. Currently, when trying to use CLI with Node.js 10.x.x, error is thrown. The problem is that we are using npm-shrinkwrap.json to keep using same versions of all dependencies, no matter how they are defined in the package.json files. The current problem is that the `unzip` package relies on `fstream` package, which depends on `graceful-fs` 3.0.11 version. This version of `graceful-fs` depends on `natives` package by using the range `^1.1.0`. In our `npm-shrinkwrap.json` this range is resolved to version 1.1.2. This version of the `natives` package does not work with Node.js 10.x.x. There's a newer one - 1.1.3 that fixes it. So the solution is to update the npm-shrinkwrap.json and use the latest version of `natives` package. Also add version 10.x.x as supported in CLI's package.json, so we'll not show warning that it is not validated.
Fatme
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Node.js 10.x.x. Currently, when trying to use CLI with Node.js 10.x.x, error is thrown. The problem is that we are using npm-shrinkwrap.json to keep using same versions of all dependencies, no matter how they are defined in the package.json files.
The current problem is that the
unzippackage relies onfstreampackage, which depends ongraceful-fs3.0.11 version. This version ofgraceful-fsdepends onnativespackage by using the range^1.1.0. In ournpm-shrinkwrap.jsonthis range is resolved to version 1.1.2. This version of thenativespackage does not work with Node.js 10.x.x. There's a newer one - 1.1.3 that fixes it. So the solution is to update the npm-shrinkwrap.json and use the latest version ofnativespackage.Also add version 10.x.x as supported in CLI's package.json, so we'll not show warning that it is not validated.
PR Checklist
What is the current behavior?
CLI cannot work with Node.js 10.x.x
What is the new behavior?
CLI works with Node.js 10.x.x
Fixes/Implements/Closes #3554.