Skip to content

fix: Build plugins when path to project has space #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

In case the path to project has space in the name and there's Android plugin that should be build, the build operation fails. The reason is usage of exec - change it to spawn, which handles the spaces correctly.

feat: Add buildAndroidPlugin hook, which is executed just before spawning the gradle build for specific plugin. The hook can be used to modify plugin's structure before building the plugin.

PR Checklist

What is the current behavior?

Building of the plugin fails in case there's a space in the path to app.

What is the new behavior?

Plugins can be successfully build.

Fixes #3560

In case the path to project has space in the name and there's Android plugin that should be build, the build operation fails. The reason is usage of exec - change it to spawn, which handles the spaces correctly.

feat: Add `buildAndroidPlugin` hook, which is executed just before spawning the gradle build for specific plugin. The hook can be used to modify plugin's structure before building the plugin.
@rosen-vladimirov rosen-vladimirov added this to the 4.0.1 milestone May 4, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this May 4, 2018
Copy link
Contributor

@Mitko-Kerezov Mitko-Kerezov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@rosen-vladimirov rosen-vladimirov merged commit bbcf9bc into release May 8, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/build-plugin-hooks branch May 8, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants