Skip to content

platform clean should preserve the nativescript version used #2496 #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2017

Conversation

etabakov
Copy link
Contributor

@etabakov etabakov commented Mar 16, 2017

Consider the following situation: There is a new version of NativeScript available (3.0) and I have existing projects using older version (2.5). I don't want to upgrade immediately for various reasons (too many effort required on my side, I'm just before releasing the app, etc). The current behaviour of the tns platform clean command is that it will first remove the specified platform and then the latest available platform (3.0) will be added. This is inconvenience in the described scenario.

As a developer, I would expect when I run tns platform clean the version of the platform added to be the same as before running the command (2.5).

Related to issue: TNS platform clean android #2496

@Plamen5kov Plamen5kov self-requested a review March 17, 2017 06:43
Copy link
Contributor

@Plamen5kov Plamen5kov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR seems great,
please provide a description for this pr:
What caused the need for it.
What issues are related (the current related issue is seen only by people using zen hub).
What's the behavior after this PR.

@etabakov etabakov changed the title platform clean should preserve the nativescript version used platform clean should preserve the nativescript version used #2496 Mar 17, 2017
@etabakov
Copy link
Contributor Author

Thanks for the feedback! More detailed description is provided.

@etabakov etabakov merged commit 8dedbcd into master Mar 17, 2017
@etabakov etabakov deleted the feature/clean-preserve-ns-version branch March 17, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants