Skip to content

TNS platform clean android #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NathanaelA opened this issue Feb 6, 2017 · 1 comment
Closed

TNS platform clean android #2496

NathanaelA opened this issue Feb 6, 2017 · 1 comment
Assignees
@etabakov
Labels
bug
Milestone
3.0.0-RC

Comments

@NathanaelA
Copy link
Contributor

I ran into a corner case; but one that is annoying if you aren't paying attention.

If you are building a product using a prior version of the runtime; lets say 2.4.1 and you do a
tns platform clean android you will end up with 2.5.0 of the runtime. When I do a "clean" I expect to maintain the SAME version of the runtimes; I don't expect to have part of my project upgraded...
@Plamen5kov
Copy link
Contributor

@NathanaelA you're absolutely right, I'll fix it as soon as possible.

@Plamen5kov Plamen5kov mentioned this issue Feb 7, 2017
Closed
@Plamen5kov Plamen5kov self-assigned this Feb 7, 2017
@Plamen5kov Plamen5kov added this to the 3.0.0 milestone Feb 7, 2017
@Plamen5kov Plamen5kov added the bug label Feb 7, 2017
@pkoleva pkoleva removed this from the 3.0.0-RC milestone Feb 24, 2017
@etabakov etabakov assigned etabakov and unassigned Plamen5kov Mar 13, 2017
@etabakov etabakov added this to the 3.0.0-RC milestone Mar 16, 2017
@etabakov etabakov mentioned this issue Mar 17, 2017
Merged
etabakov added a commit that referenced this issue Mar 17, 2017
@etabakov
platform clean should preserve the nativescript version used #2496 (#…
8dedbcd 
…2615)

* Move clean command logic to platform service

* Preserve the version of {N} on clean

* extract function that gets project version

* Do not submit undefined if version is missing
dtopuzov added a commit to NativeScript/nativescript-cli-tests that referenced this issue Apr 20, 2017
@dtopuzov
Add more tests
c3d95bb 
- Test for NativeScript/nativescript-cli#2513
- Test for NativeScript/nativescript-cli#2496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etabakov etabakov

Labels
bug
Projects
None yet
Milestone
3.0.0-RC
Development

No branches or pull requests
5 participants
@NathanaelA @etabakov @Plamen5kov @dtopuzov @pkoleva