don't add platform after tns platform clean is ran #2502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Feb 8, 2017
There was a problem hiding this comment.
According to
tns platform clean -h
The command does:
Removes and adds the selected platform to the project currently targets.
We have to either update the help content or just add the same version of the platform (as described in the related issue:
When I do a "clean" I expect to maintain the SAME version of the runtimes
|
@rosen-vladimirov I'll update the documentation, but we don't need to add a platform. The platform will remain the same in the package.json so any command will install the correct platform. No need for clean to do it. Edit: Need to change logic so cli respects what's in the |
|
I believe we no longer need these changes. |
|
Closing because of: #2615 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see more info here.
In short when
tns platform clean <platform>is ran, the command will now only clean the platform, instead of removing it and then adding the latest platform package.