Skip to content

Kconfig: Update to use imply and rid module.conf #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Conversation

DhruvaG2000
Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 commented Sep 14, 2022

Kconfig now has all the deps enabled so we can get rid of the hacky module.conf

Successfully merging this pull request will close #46

Signed-off-by: Dhruva Gole [email protected]

@DhruvaG2000 DhruvaG2000 changed the title Kconfig: Update to use imply and rid module.conf [RFC] Kconfig: Update to use imply and rid module.conf Sep 14, 2022
* Kconfig now has all the deps enabled so we can get rid of the hacky
module.conf
* deletes module.conf from all CMakelists as it will no longer be used

Signed-off-by: Dhruva Gole <[email protected]>
* Updates copyright because the file is now almost completely different
from original KConfig made by Toita, Horishi.
* Deletes all unused options

Signed-off-by: Dhruva Gole <[email protected]>
* Conditionally include sub directories specific to the
ARDUINO_API module in CMAkelists
* Solve #46

Signed-off-by: Dhruva Gole <[email protected]>
@DhruvaG2000 DhruvaG2000 changed the title [RFC] Kconfig: Update to use imply and rid module.conf Kconfig: Update to use imply and rid module.conf Sep 14, 2022
@DhruvaG2000 DhruvaG2000 self-assigned this Sep 14, 2022
@DhruvaG2000 DhruvaG2000 added the bug Something isn't working label Sep 14, 2022
Copy link
Collaborator

@szczys szczys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this is much cleaner without the need to include module.conf.

I tested building for the Arduino API and building unrelated samples and both are working for me.

@DhruvaG2000
Copy link
Collaborator Author

Great work, this is much cleaner without the need to include module.conf.

I tested building for the Arduino API and building unrelated samples and both are working for me.

Thanks for taking the time to test and review my PR.

@DhruvaG2000 DhruvaG2000 merged commit a88eda6 into main Sep 16, 2022
@DhruvaG2000 DhruvaG2000 deleted the restruct-kconfig branch November 19, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that this module defaults to "not selected" in KConfig
2 participants